Pages: 1 [2] 3
Author Topic: mrfa >95% = LAMFA 0% column???  (Read 26082 times)
elRey
Hero Member
*****

Karma: +32/-1
Offline Offline

Posts: 565


« Reply #15 on: June 29, 2012, 10:57:44 AM »

Quote
This was with first column at 0% and lambda = 1. I believe last column was stock %.

ARGH sorry i accidentially edited a post that wasn't mine again :/
somebody needs to move that button away from the quote area :/

I'm so sorry, it doesn't keep a record of the original post

-nye
« Last Edit: June 29, 2012, 11:50:13 AM by nyet » Logged
nyet
Administrator
Hero Member
*****

Karma: +604/-166
Online Online

Posts: 12234


WWW
« Reply #16 on: June 29, 2012, 11:03:27 AM »

png export from ecuxplot please..

or at least the raw .csv Smiley
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
elRey
Hero Member
*****

Karma: +32/-1
Offline Offline

Posts: 565


« Reply #17 on: June 29, 2012, 11:24:00 AM »

raw csv and screenshot from similar file.

Logged
nyet
Administrator
Hero Member
*****

Karma: +604/-166
Online Online

Posts: 12234


WWW
« Reply #18 on: June 29, 2012, 11:50:47 AM »

So this is with mrfa axis data 0-100 or 0-1.0?
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
nyet
Administrator
Hero Member
*****

Karma: +604/-166
Online Online

Posts: 12234


WWW
« Reply #19 on: June 29, 2012, 11:52:38 AM »

All I can say is when my first column = 0%, WOT = first column values. I'll post logs of this behavior. I confirm it by changing lambda for first row and WOT lamfa reflected my new values. But it was a small margin that was affected. ~>96% is where it would jump back to using first column.

Logs to come.

Perhaps some sort of fencepost/sign error.

Could be an actual bug in the code?
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
elRey
Hero Member
*****

Karma: +32/-1
Offline Offline

Posts: 565


« Reply #20 on: June 29, 2012, 12:01:37 PM »

My map factor is 0-100% but let me see what the actual hex values are.
Logged
elRey
Hero Member
*****

Karma: +32/-1
Offline Offline

Posts: 565


« Reply #21 on: June 29, 2012, 12:39:33 PM »

I guess decimal values would make more sense:

stock MFRA axis HiLo:

0
16589
19507
29594
31089
32000

What I see via map scale of 0.003052

stock:

0.0000
50.6296
59.5354
90.3209
94.8836
97.6640
« Last Edit: June 29, 2012, 12:41:23 PM by elRey » Logged
nyet
Administrator
Hero Member
*****

Karma: +604/-166
Online Online

Posts: 12234


WWW
« Reply #22 on: June 29, 2012, 12:45:35 PM »

I see that stock is 0xa4 - 0x148 (0.5 - 1.001) in mbox

or are we talkign about a differnent box?

also, it should be LoHi (little endian)
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
elRey
Hero Member
*****

Karma: +32/-1
Offline Offline

Posts: 565


« Reply #23 on: June 29, 2012, 04:53:00 PM »

log filename says it, 032HS
Logged
nyet
Administrator
Hero Member
*****

Karma: +604/-166
Online Online

Posts: 12234


WWW
« Reply #24 on: June 29, 2012, 05:30:46 PM »

Ah. No wonder. Don't know anything about that ecu :/
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
nokiafix
Full Member
***

Karma: +19/-2
Offline Offline

Posts: 124


« Reply #25 on: July 02, 2012, 01:59:33 PM »

Same here but the other way around... aint got a clue about the S4 ecu lol
Logged
prj
Hero Member
*****

Karma: +915/-428
Offline Offline

Posts: 5845


« Reply #26 on: July 04, 2012, 10:19:50 AM »

I might have an idea. I had some confusion with defining LAMFA correctly as well, especially since it seemed misdefined in one of the DAMOS floating around.

I will use the 2.7 K-Box for this example.

Here is the data for the LAMFA table:
0F 06 19 4B 4F 52 55 58 5E 61 64 6B 71 7D 84 8A
96
00 A4 00 C3 00 E4 00 05 01 26 01 48 01 80 80
80 80 80 80 80 80 80 80 80 80 80 80 80 80 80 80
80 80 80 80 80 80 80 80 80 80 80 80 80 80 80 80
80 80 80 80 80 80 80 80 80 80 80 80 80 80 80 80
80 80 80 80 80 80 80 80 80 80 80 80 80 80 80 80
80 80 80 80 80 80 80 80 80 80 80 80 80 80 80 80
80 80 80 80 80 80 80 80


Okay, so the first two numbers in red are the axis lengths. The first axis is 0F or 15 data points. This is the RPM axis, highlighted in blue.
The second axis is the mrfa_w axis, which is six 16 bit data points highlighted in purple.
The map starts after that, and is highlighted in green.

Now comes the interesting part, and I think this is where you could be going wrong.
After the 1st axis, there is a "00". This is not part of anything, perhaps it was there to simply accommodate a 16th value, or perhaps it is used for something else I don't know. I have seen this defined wrong, so that the axis was set to LSB first, and the map was being moved 1 cell as well.

Let's see what happens when the map is defined correctly in TunerPro:


And what happens if you define it incorrectly:


One of the DAMOSes I had actually had it incorrectly defined. This was so confusing, that I had no other choice than to look at the code.
In my file this segment starts at 0x1CAC8, so:
0x1CAC8 - nmot axis length
0x1CAC9 - mrfa_w axis length
0x1CACA - nmot axis
0x1CADA - mrfa_w axis
0x1CAE6 - map values

This is confirmed by the code:


You can see how mrfa_w and nmot are loaded as arguments.
Then the map location is loaded - 0x1CAE6, not 0x1CAE5!
After that the nmot axis location is loaded, followed by the length - LAMFA_RPM_AXIS_LEN is 0x1CAC8 (or 0x81CAC8).
And now the mrfa_w axis is loaded the same way, by first loading the location and then the length of the axis.
Finally the map reading function is called.

Make 100% sure that you have this defined correctly, because if you don't, this is the behaviour you would get. Don't trust the DAMOS, trust the code.
« Last Edit: July 04, 2012, 10:23:39 AM by prj » Logged

PM's will not be answered, so don't even try.
Log your car properly.
nyet
Administrator
Hero Member
*****

Karma: +604/-166
Online Online

Posts: 12234


WWW
« Reply #27 on: July 04, 2012, 10:26:00 AM »

Yes, I've said this several times, there are a LOT of bad damos files around with unaligned axis addresses.

If you EVER see a location that isn't 16-bit aligned (especially if the data is 16-bit), you know something is wrong.

The error, in this case, is the m-box, where LAMFA is *disabled* AND the axis data is wrong (yes, I have the correct offset).

The data is off by a factor of 100.

See for yourself. Get an mbox, and look at 0x1C382 (6x1, LoHi, 16-bit)

 http://nefariousmotorsports.com/forum/index.php/topic,141.msg9068.html#msg9068
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
prj
Hero Member
*****

Karma: +915/-428
Offline Offline

Posts: 5845


« Reply #28 on: July 04, 2012, 10:28:49 AM »

No, I know that.
But you know, the way OP was pointing out that his stuff "wraps around" made me think that this could be exactly his problem.
Anyway, since I know where the table is read in the code now, I can now locate LAMFA correctly on any ME7 ECU Smiley
Logged

PM's will not be answered, so don't even try.
Log your car properly.
Rick
Hero Member
*****

Karma: +62/-4
Offline Offline

Posts: 704


« Reply #29 on: July 04, 2012, 03:12:20 PM »

I realised something was up with the damos when it was defined as 16bit HiLo!
Logged
Pages: 1 [2] 3
  Print  
 
Jump to:  

Powered by SMF 1.1.21 | SMF © 2015, Simple Machines Page created in 0.036 seconds with 16 queries. (Pretty URLs adds 0.00099999999999999s, 0q)