|
masterj
|
 |
« Reply #195 on: February 02, 2013, 05:45:35 AM »
|
|
|
For some reason I can't make NLS work. LC works perfectly but not NLS. Could someone check my file I've posted earlier?
|
|
|
|
|
Logged
|
|
|
|
|
littco
|
|
« Reply #196 on: February 02, 2013, 06:12:28 AM »
|
|
|
For some reason I can't make NLS work. LC works perfectly but not NLS. Could someone check my file I've posted earlier?
ignore that.. I was talking cr*p didn't see you had moved the variables |
|
|
|
« Last Edit: February 02, 2013, 06:17:51 AM by littco »
|
Logged
|
|
|
|
|
littco
|
|
« Reply #197 on: February 02, 2013, 06:48:49 AM »
|
|
|
sub_8A6860: ; CODE XREF: sub_8A0BFAP
seg009:000A6860 jnb word_FD4A.13, loc_8A688A
seg009:000A6864 mov r4, word_381CB8
seg009:000A6868 exts #81h, #1 ; 'ü'
seg009:000A686C mov r9, word_817400
seg009:000A6870 cmp r4, r9
seg009:000A6872 jmpr cc_NC, loc_8A688A
seg009:000A6874 mov r4, word_F89E
seg009:000A6878 exts #81h, #1 ; 'ü'
seg009:000A687C mov r9, word_817402
seg009:000A6880 cmp r4, r9
seg009:000A6882 jmpr cc_ULE, loc_8A688A
seg009:000A6884 movb byte_380BA4, ZEROS
seg009:000A6888 jmpr cc_UC, loc_8A68E8
seg009:000A688A ; ---------------------------------------------------------------------------
seg009:000A688A
seg009:000A688A loc_8A688A: ; CODE XREF: sub_8A6860j
seg009:000A688A ; sub_8A6860+12j ...
seg009:000A688A jnb word_FD4A.13, loc_8A68E0
seg009:000A688E jb word_FD4A.11, loc_8A68D6
seg009:000A6892 mov r4, word_F89E
seg009:000A6896 exts #81h, #1 ; 'ü'
seg009:000A689A mov r9, word_817406
seg009:000A689E cmp r4, r9
seg009:000A68A0 jmpr cc_ULE, loc_8A68D6
seg009:000A68A2 movbz r4, byte_3809A8
seg009:000A68A6 exts #81h, #1 ; 'ü'
seg009:000A68AA movbz r9, byte_817408
seg009:000A68AE cmp r4, r9
seg009:000A68B0 jmpr cc_ULE, loc_8A68D6
seg009:000A68B2 exts #38h, #1 ; '8'
seg009:000A68B6 mov r4, word_38B800
seg009:000A68BA exts #81h, #1 ; 'ü'
seg009:000A68BE mov r9, word_817404
seg009:000A68C2 cmp r4, r9
seg009:000A68C4 jmpr cc_NC, loc_8A68E8
seg009:000A68C6 movb byte_380BA4, ZEROS
seg009:000A68CA add r4, #1
seg009:000A68CC exts #38h, #1 ; '8'
seg009:000A68D0 movb word_38B800, rl4
seg009:000A68D4 jmpr cc_UC, loc_8A68E8
seg009:000A68D6 ; ---------------------------------------------------------------------------
seg009:000A68D6
seg009:000A68D6 loc_8A68D6: ; CODE XREF: sub_8A6860+2Ej
seg009:000A68D6 ; sub_8A6860+40j ...
seg009:000A68D6 exts #38h, #1 ; '8'
seg009:000A68DA mov word_38B800, ONES
seg009:000A68DE jmpr cc_UC, loc_8A68E8
seg009:000A68E0 ; ---------------------------------------------------------------------------
seg009:000A68E0
seg009:000A68E0 loc_8A68E0: ; CODE XREF: sub_8A6860:loc_8A688Aj
seg009:000A68E0 exts #38h, #1 ; '8'
seg009:000A68E4 mov word_38B800, ZEROS
seg009:000A68E8
seg009:000A68E8 loc_8A68E8: ; CODE XREF: sub_8A6860+28j
seg009:000A68E8 ; sub_8A6860+64j ...
seg009:000A68E8 movb rl4, byte_381C89
seg009:000A68EC rets
seg009:000A68EC ; End of function sub_8A6860
I checked the code and it looks ok.
Only suggestion is that I have put B_br instead of B_brems and not had an issue, worth trying?
25 90 needs to replace 25 D0
You know you have this
4E 4F 52 45 41 44 00 00 00 00 00 00 03 32 00 00 NOREAD......2.
|
|
|
|
|
Logged
|
|
|
|
|
masterj
|
|
« Reply #198 on: February 02, 2013, 08:18:24 AM »
|
|
|
sub_8A6860: ; CODE XREF: sub_8A0BFAP
seg009:000A6860 jnb word_FD4A.13, loc_8A688A
seg009:000A6864 mov r4, word_381CB8
seg009:000A6868 exts #81h, #1 ; 'ü'
seg009:000A686C mov r9, word_817400
seg009:000A6870 cmp r4, r9
seg009:000A6872 jmpr cc_NC, loc_8A688A
seg009:000A6874 mov r4, word_F89E
seg009:000A6878 exts #81h, #1 ; 'ü'
seg009:000A687C mov r9, word_817402
seg009:000A6880 cmp r4, r9
seg009:000A6882 jmpr cc_ULE, loc_8A688A
seg009:000A6884 movb byte_380BA4, ZEROS
seg009:000A6888 jmpr cc_UC, loc_8A68E8
seg009:000A688A ; ---------------------------------------------------------------------------
seg009:000A688A
seg009:000A688A loc_8A688A: ; CODE XREF: sub_8A6860j
seg009:000A688A ; sub_8A6860+12j ...
seg009:000A688A jnb word_FD4A.13, loc_8A68E0
seg009:000A688E jb word_FD4A.11, loc_8A68D6
seg009:000A6892 mov r4, word_F89E
seg009:000A6896 exts #81h, #1 ; 'ü'
seg009:000A689A mov r9, word_817406
seg009:000A689E cmp r4, r9
seg009:000A68A0 jmpr cc_ULE, loc_8A68D6
seg009:000A68A2 movbz r4, byte_3809A8
seg009:000A68A6 exts #81h, #1 ; 'ü'
seg009:000A68AA movbz r9, byte_817408
seg009:000A68AE cmp r4, r9
seg009:000A68B0 jmpr cc_ULE, loc_8A68D6
seg009:000A68B2 exts #38h, #1 ; '8'
seg009:000A68B6 mov r4, word_38B800
seg009:000A68BA exts #81h, #1 ; 'ü'
seg009:000A68BE mov r9, word_817404
seg009:000A68C2 cmp r4, r9
seg009:000A68C4 jmpr cc_NC, loc_8A68E8
seg009:000A68C6 movb byte_380BA4, ZEROS
seg009:000A68CA add r4, #1
seg009:000A68CC exts #38h, #1 ; '8'
seg009:000A68D0 movb word_38B800, rl4
seg009:000A68D4 jmpr cc_UC, loc_8A68E8
seg009:000A68D6 ; ---------------------------------------------------------------------------
seg009:000A68D6
seg009:000A68D6 loc_8A68D6: ; CODE XREF: sub_8A6860+2Ej
seg009:000A68D6 ; sub_8A6860+40j ...
seg009:000A68D6 exts #38h, #1 ; '8'
seg009:000A68DA mov word_38B800, ONES
seg009:000A68DE jmpr cc_UC, loc_8A68E8
seg009:000A68E0 ; ---------------------------------------------------------------------------
seg009:000A68E0
seg009:000A68E0 loc_8A68E0: ; CODE XREF: sub_8A6860:loc_8A688Aj
seg009:000A68E0 exts #38h, #1 ; '8'
seg009:000A68E4 mov word_38B800, ZEROS
seg009:000A68E8
seg009:000A68E8 loc_8A68E8: ; CODE XREF: sub_8A6860+28j
seg009:000A68E8 ; sub_8A6860+64j ...
seg009:000A68E8 movb rl4, byte_381C89
seg009:000A68EC rets
seg009:000A68EC ; End of function sub_8A6860
I checked the code and it looks ok.
Only suggestion is that I have put B_br instead of B_brems and not had an issue, worth trying?
25 90 needs to replace 25 D0
You know you have this
4E 4F 52 45 41 44 00 00 00 00 00 00 03 32 00 00 NOREAD......2.
Yes I know that I have set NOREAD... Also why use b_br instead b_brems? B_brems is correct, because I have logged this bit to see if it is set when I press on brakes... One more thing that could affect NLS would be ram address. Currently I am using 0x38B800, but when I tried to log it with me7logger I always get decimal value of 12. This is from my ecu file: ;Name , {Alias} , Address, Size, Bitmask, {Unit}, S, I, A, B, Comment
NLS_COUNT , {NLS Count} , 0x38B800, 1, 0x0000, {#} , 0, 0, 1, 0, {NLS COUNT}Does this look normal? |
|
|
|
« Last Edit: February 02, 2013, 08:30:15 AM by masterj »
|
Logged
|
|
|
|
|
littco
|
|
« Reply #199 on: February 02, 2013, 08:42:47 AM »
|
|
|
I use B_br as a) it works without issue and I know it works and B) it's listed on the .ECU files so you don't have to worry about finding it. Ease more than anything, If Brems works for you then great.
I'm sure it wouldn't make a difference but have you tried putting the NLS counter in the original ram location 384ff0? again only suggesting it as it works there.
Like I said I couldn't see anything wrong with the coding so not sure.
|
|
|
|
|
Logged
|
|
|
|
|
masterj
|
|
« Reply #200 on: February 07, 2013, 10:24:48 AM »
|
|
|
I use B_br as a) it works without issue and I know it works and B) it's listed on the .ECU files so you don't have to worry about finding it. Ease more than anything, If Brems works for you then great.
I'm sure it wouldn't make a difference but have you tried putting the NLS counter in the original ram location 384ff0? again only suggesting it as it works there.
Like I said I couldn't see anything wrong with the coding so not sure.
Well I tried original location and it works now... Looks like I just took bad(used???) ram address, even though ida showed me it is free.... Anyway, lovin NLS! Thanks littco for giving me suggestions... |
|
|
|
|
Logged
|
|
|
|
vagenwerk
Full Member
Karma: +2/-0
 Offline
Posts: 182
|
|
« Reply #201 on: February 10, 2013, 01:31:01 PM »
|
|
|
Hi guys
Could you check if I did it correctly on my file?
My Call DA 8A 00 9C
Variables at 17EC0
tsrldyn 0x380BB5,
B_kuppl 0x00FD4E.3
nmot_w 0x00F89E,
wped 0x3809B1,
B_brems 0x00FD4C.15
Function Parameters:
-------------------
SpeedThreshold: 0x17EC0 size 2, 16bit LSB
LaunchRPM: 0x17EC2 size 2, 16bit LSB
IgnitionCutDuration: 0x17EC4 size 2, 16bit LSB
RPMThreshold: 0x17EC6 size 2, 16bit LSB
FTOMN 0ms
Code
9A 27 13 30 F2 F4 40 8E D7 00 81 00 F2 F9 C0 7E
40 49 9D 0B F2 F4 9E F8 D7 00 81 00 F2 F9 C2 7E
40 49 FD 03 F7 8E B5 8B 0D 2F 9A 27 29 30 8A 25
22 F0 F2 F4 9E F8 D7 00 81 00 F2 F9 C6 7E 40 49
FD 1A C2 F4 B1 89 D7 00 81 00 C2 F9 C8 7E 40 49
FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9
C4 7E 40 49 9D 11 F7 8E B5 8B 08 41 D7 00 38 00
F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04
D7 00 38 00 F6 8E F0 4F F3 F8 F3 8A DB 00 FF FF
Could You confirm checksum for me? Winols sometimes doesn't cover full area chksm adress....i won't brick ecu.
Is there any wrong ?
|
|
|
|
« Last Edit: February 12, 2013, 05:19:09 AM by gregor10 »
|
Logged
|
|
|
|
vagenwerk
Full Member
Karma: +2/-0
Offline
Posts: 182
|
|
« Reply #202 on: February 11, 2013, 01:12:58 PM »
|
|
|
NLS works perfect - really shift like a butter ! ALS give nice Boom boom boom and boost build  THANKS GUYS ! |
|
|
|
« Last Edit: February 12, 2013, 05:19:58 AM by gregor10 »
|
Logged
|
|
|
|
multitek
Newbie
Karma: +1/-0
Offline
Posts: 11
|
|
« Reply #203 on: April 24, 2013, 11:19:28 AM »
|
|
|
Can somebody please help here,cant find B_kuppl 14= ?
Can anyone check the rest code is correct before i put it to my ecu and explode it..??
i've attached the .ecu file
Function Location: B3000
Variables: 17E00
call A1D90: DA 8B 00 30
tsrldyn 0x380BB7 0BB7> 8BB7> B7 8B
B_kuppl 0x00FD4E.14 14: 4E> 27
vfil_w 0x381C0C 0C 9C> 0C 9C
nmot_w 0x00F89E 9E F8
wped 0x3809B1 09B1> 89B1> B1 89
B_br 0x00FD4E.10 10: A0 4E> 27
counter_NoLiftShift: 0x384FF0>>> F0 4F
Function Parameters:
-------------------
SpeedThreshold: 0x17E00 size 2, 16bit LSB
LaunchRPM: 0x17E02 size 2, 16bit LSB
IgnitionCutDuration: 0x17E04 size 2, 16bit LSB
RPMThreshold: 0x17E06 size 2, 16bit LSB
AccPedalThreshold: 0x17E08 size 1, 8bit LSB
FTOMN 1A43D SET =0
9A 27 13 ?? F2 F4 0C 9C D7 00 81 00 F2 F9 C0 7E
40 49 9D 0B F2 F4 9E F8 D7 00 81 00 F2 F9 C2 7E
40 49 FD 03 F7 8E B7 8B 0D 2F 9A 27 29 ?? 8A 27
22 A0 F2 F4 9E F8 D7 00 81 00 F2 F9 C6 7E 40 49
FD 1A C2 F4 B1 89 D7 00 81 00 C2 F9 C8 7E 40 49
FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9
C4 7E 40 49 9D 11 F7 8E B7 8B 08 41 D7 00 38 00
F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04
D7 00 38 00 F6 8E F0 4F F3 F8 F3 8A DB 00 FF FF
|
|
|
|
« Last Edit: April 25, 2013, 08:35:35 AM by multitek »
|
Logged
|
|
|
|
|
sn00k
|
|
« Reply #204 on: April 25, 2013, 04:52:06 PM »
|
|
|
9A 27 13 ?? F2 F4 0C 9C D7 00 81 00 F2 F9 C0 7E
40 49 9D 0B F2 F4 9E F8 D7 00 81 00 F2 F9 C2 7E
40 49 FD 03 F7 8E B7 8B 0D 2F 9A 27 29 ?? 8A 27
22 A0 F2 F4 9E F8 D7 00 81 00 F2 F9 C6 7E 40 49
FD 1A C2 F4 B1 89 D7 00 81 00 C2 F9 C8 7E 40 49
FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9
C4 7E 40 49 9D 11 F7 8E B7 8B 08 41 D7 00 38 00
F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04
D7 00 38 00 F6 8E F0 4F F3 F8 F3 8A DB 00 FF FF
?? = E0 complete function when conditions placed starting at 17E00 could/should look like this for the 032HN ecu.. make sure you set FTOMN(1A43D) to 0 also make sure to set conditions and make the link-in correctly. 9A 27 13 E0 F2 F4 0C 9C D7 00 81 00 F2 F9 00 7E 40 49 9D 0B F2 F4 9E F8 D7 00 81 00 F2 F9 02 7E 40 49 FD 03 F7 8E B7 8B 0D 2F 9A 27 29 E0 8A 27 22 C0 F2 F4 9E F8 D7 00 81 00 F2 F9 06 7E 40 49 FD 1A C2 F4 B1 89 D7 00 81 00 C2 F9 08 7E 40 49 FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9 04 7E 40 49 9D 11 F7 8E B7 8B 08 41 D7 00 38 00 F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04 D7 00 38 00 F6 8E F0 4F F3 F8 9D 89 DB 00 FF FF |
|
|
|
|
Logged
|
|
|
|
multitek
Newbie
Karma: +1/-0
Offline
Posts: 11
|
|
« Reply #205 on: April 26, 2013, 12:41:52 AM »
|
|
|
?? = E0
complete function when conditions placed starting at 17E00 could/should look like this for the 032HN ecu..
make sure you set FTOMN(1A43D) to 0
also make sure to set conditions and make the link-in correctly.
9A 27 13 E0 F2 F4 0C 9C D7 00 81 00 F2 F9 00 7E
40 49 9D 0B F2 F4 9E F8 D7 00 81 00 F2 F9 02 7E
40 49 FD 03 F7 8E B7 8B 0D 2F 9A 27 29 E0 8A 27
22 C0 F2 F4 9E F8 D7 00 81 00 F2 F9 06 7E 40 49
FD 1A C2 F4 B1 89 D7 00 81 00 C2 F9 08 7E 40 49
FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9
04 7E 40 49 9D 11 F7 8E B7 8B 08 41 D7 00 38 00
F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04
D7 00 38 00 F6 8E F0 4F F3 F8 9D 89 DB 00 FF FF
Thanks so much sn00k.
the only thing i cant figure out is the calculation
for b_kuppl and b_brems.i am a bit confused
b_brems=b_br or b_brems=b__kuppl -2 ??
and how we convert the bitmask numbers?
can you analyze a bit more the way?(14=E0)
(10=C0)
Many thanks again for sharing these knowledge!
|
|
|
|
|
Logged
|
|
|
|
multitek
Newbie
Karma: +1/-0
Offline
Posts: 11
|
|
« Reply #206 on: April 26, 2013, 12:56:47 PM »
|
|
|
Is it possible someone check my code and calculate the checksumm,
i am not sure it's corrected properely and i dont want to burn my ecu.
Thanks in advance.
Function Location: B3000
Variables: 17E00
call A1D92: DA 8B 00 30
tsrldyn 0x380BB7 0BB7> 8BB7> B7 8B
B_kuppl 0x00FD4E.14 14: E0 4E> 27
vfil_w 0x381C0C 0C 9C> 0C 9C
nmot_w 0x00F89E 9E F8
wped 0x3809B1 09B1> 89B1> B1 89
B_brems 0x00FD4E.12 12: C0 4E> 27
counter_NoLiftShift: 0x384FF0>>> F0 4F
Function Parameters:
-------------------
SpeedThreshold: 0x17E00 size 2, 16bit LSB 3KM/H
LaunchRPM: 0x17E02 size 2, 16bit LSB 4500RPM
IgnitionCutDuration: 0x17E04 size 2, 16bit LSB 200M/SEC
RPMThreshold: 0x17E06 size 2, 16bit LSB 5500rpm
AccPedalThreshold: 0x17E08 size 1, 8bit LSB 90%
FTOMN 1A43D SET =0
9A 27 13 E0 F2 F4 0C 9C D7 00 81 00 F2 F9 00 7E
40 49 9D 0B F2 F4 9E F8 D7 00 81 00 F2 F9 02 7E
40 49 FD 03 F7 8E B7 8B 0D 2F 9A 27 29 E0 8A 27
22 C0 F2 F4 9E F8 D7 00 81 00 F2 F9 06 7E 40 49
FD 1A C2 F4 B1 89 D7 00 81 00 C2 F9 08 7E 40 49
FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9
04 7E 40 49 9D 11 F7 8E B7 8B 08 41 D7 00 38 00
F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04
D7 00 38 00 F6 8E F0 4F F3 F8 9D 89 DB 00 FF FF
|
|
|
|
« Last Edit: April 27, 2013, 07:11:16 AM by multitek »
|
Logged
|
|
|
|
cactusgreens4
Full Member
Karma: +2/-0
Offline
Posts: 110
|
|
« Reply #207 on: April 26, 2013, 01:52:05 PM »
|
|
|
Could someone please help me out? I have been trying forever now to add ALNLS to my tune and I cannot for the life of me figure it out no matter how I edit the code. With tuner pro and setzi's xdf or with sn00ks pdf. I just cannot seem to make it work. So I was hoping someone could maybe take a few minutes and look at my file and see if what I have done is not only correct but also done correctly. It is an m box file so my locations and everything are the same setzi's but I will post them anyway also I followed the instructions in the wiki here: http://www.nefariousmotorsports.com/wiki/index.php/Adding_anti-lag_launch_control_and_no-lift_shift and also in sn00k's pdf and nothing seems to work for me. My file is just Notorious stage 2 file with my krkte and tvub for larger injectors. Along with the ALNLS code. If anyone is willing to help that would be greatly appreciated. And thanks in advance! My call: DA 88 00 E8 Variables at 17E00 tsrldyn: 0x380DAC B_kuppl: 0x00FD56.8 vfil_w: 0x380E40 nmot_w: 0x00F87A wped: 0x380B02 B_brems: 0x00FD56.6 function parameters SpeedThreshold: 0x17E00 size 2, 16bit LSB LaunchRPM: 0x17E02 size 2, 16bit LSB IgnitionCutDuration: 0x17E04 size 2, 16bit LSB RPMThreshold: 0x17E06 size 2, 16bit LSB AccPedalThreshold: 0x17E08 size 1, 8bit LSB Code 9A 2B 13 80 F2 F4 40 8E D7 00 81 00 F2 F9 00 7E 40 49 9D 0B F2 F4 7A F8 D7 00 81 00 F2 F9 02 7E 40 49 FD 03 F7 8E AC 8D 0D 2F 9A 2B 29 80 8A 2B 22 60 F2 F4 7A F8 D7 00 81 00 F2 F9 06 7E 40 49 FD 1A C2 F4 02 8B D7 00 81 00 C2 F9 08 7E 40 49 FD 12 D7 00 38 00 F2 F4 F0 4F D7 00 81 00 F2 F9 04 7E 40 49 9D 11 F7 8E AC 8D 08 41 D7 00 38 00 F7 F8 F0 4F 0D 09 D7 00 38 00 F6 8F F0 4F 0D 04 D7 00 38 00 F6 8E F0 4F F3 F8 F3 8A DB 00 FF FF |
|
|
|
|
Logged
|
|
|
|
|
sn00k
|
|
« Reply #208 on: April 27, 2013, 04:41:09 AM »
|
|
|
Could someone please help me out? I have been trying forever now to add ALNLS to my tune and I cannot for the life of me figure it out no matter how I edit the code. had a quick look at your bin.. i would suggest you move the function to the original A9C00 and make the call to it there.. as per the principle "dont fix what aint broken".. we all know it works when placed THERE, so why move it..?  |
|
|
|
|
Logged
|
|
|
|
|
littco
|
|
« Reply #209 on: April 27, 2013, 04:55:28 AM »
|
|
|
Here is an xdf with the patch function for adding ALS into the HN.
Just open the the bin then select the xdf and click on the patch and patch it in.
save the .bin and there you have it.
Maybe others can Add some more :-)
|
|
|
|
|
Logged
|
|
|
|
|
