totti
Full Member
Karma: +15/-29
 Offline
Posts: 227
|
 |
« on: October 28, 2021, 12:39:47 PM »
|
|
|
Hi,
I would like to share with you a switchable pops&bangs file. You can disassemble it. Just the custom code added to the original data.
If CC switch is off pops&bangs is active. Zwout and lamfaw_w can be changed to tune for your setup.
Zwout address: 0xA595C
lamfaw_w address: 0xA5986
|
|
|
|
« Last Edit: October 28, 2021, 12:45:18 PM by totti »
|
Logged
|
|
|
|
|
elRey
|
|
« Reply #1 on: October 28, 2021, 01:52:21 PM »
|
|
|
Cool. Thank you. Downloading and will take a look.
Are you saving by modifying the single point values at Zwout address: 0xA595C andlamfaw_w address: 0xA5986 we can fine tune how aggressive the pops and bangs are?
|
|
|
|
|
Logged
|
|
|
|
totti
Full Member
Karma: +15/-29
Offline
Posts: 227
|
|
« Reply #2 on: October 28, 2021, 11:34:11 PM »
|
|
|
Cool. Thank you. Downloading and will take a look.
Are you saving by modifying the single point values at Zwout address: 0xA595C andlamfaw_w address: 0xA5986 we can fine tune how aggressive the pops and bangs are?
Yes currently you can modify directly the mov command parameter. Next step would be to place the tune parameters to 0x17xxx. |
|
|
|
|
Logged
|
|
|
|
xXxCryxXx
Full Member
Karma: +3/-17
Offline
Posts: 157
|
|
« Reply #3 on: November 05, 2021, 01:16:32 PM »
|
|
|
Hi,
I would like to share with you a switchable pops&bangs file. You can disassemble it. Just the custom code added to the original data.
If CC switch is off pops&bangs is active. Zwout and lamfaw_w can be changed to tune for your setup.
Zwout address: 0xA595C
lamfaw_w address: 0xA5986
Hey  Can you also upload the ori file too? Thanks for providing this file! |
|
|
|
|
Logged
|
|
|
|
|
|
|
Dave9n3
|
|
« Reply #5 on: November 22, 2021, 04:48:44 PM »
|
|
|
First off thanks for uploading this. I've just spent a while trying to disassemble it and work out what it's doing for my own benefit, and maybe some other noobs like me.
A few questions I have:
- I think I can see the two mov's where values are put into register to later be forced into both zwout and lamfaw_w, If i have these correct, is there any simple conversion we can do to turn these values into something more meaningful/easier to adjust?
- Can anyone explain what the 'movb byte_380ADA, r16' is doing/what its for?
Wold appreciate it if someone could have a quick look over what I've commented on the function below and clear up any errors I've made/correct me
:95860 jb word_FD10.4, loc_895868 ; jump to location if cc sw is set (p&b off)
seg003:95864 movb rl6, #0FFh ; move 0FFh into r16
seg003:95868
seg003:95868 loc_895868: ; CODE XREF: sub_895848+18j
seg003:95868 movb byte_380ADA, rl6 ; move byte_380ada into r16 (what is byte380ADA?)
seg003:9586C rets
seg003:9586C ; End of function sub_895848
seg003:9586C
seg003:9586E
seg003:9586E ; =============== S U B R O U T I N E =======================================
seg003:9586E
seg003:9586E
seg003:9586E sub_89586E:
seg003:9586E bset r15.15
seg003:95870 bset r15.15
seg003:95872 bset r15.15
seg003:95874 bset r15.15
seg003:95876 jb word_FD10.4, loc_895896 ; jump to location if cc sw set (p&b off)
seg003:9587A movb rl4, nmot ; move engine speed into r14
seg003:9587E cmpb rl4, #3Eh ; '>' ; compare engine speed with #3eh
seg003:95882 jmpr cc_ULE, loc_895896 ; jump to location if 3Eh is less than value in r14 from nmot
seg003:95884 exts #38h, #1 ; '8'
seg003:95888 movb rl4, wped ; move wped into r14
seg003:9588C cmpb rl4, #0 ; compare r14 wped with #0
seg003:9588E jmpr cc_NZ, loc_895896 ; jump to location if wped is not zero
seg003:95890 movb rl4, #0E8h ; 'Þ' ; Move value into r14 to later force zwout
seg003:95890 ; End of function sub_89586E
seg003:95890
seg003:95894
seg003:95894 ; =============== S U B R O U T I N E =======================================
seg003:95894
seg003:95894
seg003:95894 sub_895894: ; CODE XREF: sub_812EF0+12P
seg003:95894 movb [r12], rl4 ; load value from r14 into r12 to force zwout
seg003:95896
seg003:95896 loc_895896: ; CODE XREF: sub_89586E+8j
seg003:95896 ; sub_89586E+14j ...
seg003:95896 movb zwout, [r12]
seg003:9589A rets
seg003:9589A ; End of function sub_895894
|
|
|
|
|
Logged
|
|
|
|
|
Dave9n3
|
|
« Reply #6 on: November 22, 2021, 05:01:15 PM »
|
|
|
Wouldn't let me edit my previous post so I've re pasted the full commented function here.
:95860 jb word_FD10.4, loc_895868 ; jump to location if cc sw is set (p&b off)
seg003:95864 movb rl6, #0FFh ; move 0FFh into r16
seg003:95868
seg003:95868 loc_895868: ; CODE XREF: sub_895848+18j
seg003:95868 movb byte_380ADA, rl6 ; move byte_380ada into r16 (what is byte380ADA?)
seg003:9586C rets
seg003:9586C ; End of function sub_895848
seg003:9586C
seg003:9586E
seg003:9586E ; =============== S U B R O U T I N E =======================================
seg003:9586E
seg003:9586E
seg003:9586E sub_89586E:
seg003:9586E bset r15.15
seg003:95870 bset r15.15
seg003:95872 bset r15.15
seg003:95874 bset r15.15
seg003:95876 jb word_FD10.4, loc_895896 ; jump to location if cc sw set (p&b off)
seg003:9587A movb rl4, nmot ; move engine speed into r14
seg003:9587E cmpb rl4, #3Eh ; '>' ; compare engine speed with #3eh
seg003:95882 jmpr cc_ULE, loc_895896 ; jump to location if 3Eh is less than value in r14 from nmot
seg003:95884 exts #38h, #1 ; '8'
seg003:95888 movb rl4, wped ; move wped into r14
seg003:9588C cmpb rl4, #0 ; compare r14 wped with #0
seg003:9588E jmpr cc_NZ, loc_895896 ; jump to location if wped is not zero
seg003:95890 movb rl4, #0E8h ; 'Þ' ; Move value into r14 to later force zwout
seg003:95890 ; End of function sub_89586E
seg003:95890
seg003:95894
seg003:95894 ; =============== S U B R O U T I N E =======================================
seg003:95894
seg003:95894
seg003:95894 sub_895894: ; CODE XREF: sub_812EF0+12P
seg003:95894 movb [r12], rl4 ; load value from r14 into r12 to force zwout
seg003:95896
seg003:95896 loc_895896: ; CODE XREF: sub_89586E+8j
seg003:95896 ; sub_89586E+14j ...
seg003:95896 movb zwout, [r12]
seg003:9589A rets
seg003:9589A ; End of function sub_895894
seg003:9589A
seg003:9589C
seg003:9589C ; =============== S U B R O U T I N E =======================================
seg003:9589C
seg003:9589C
seg003:9589C sub_89589C:
seg003:9589C bset r15.15
seg003:9589E bset r15.15
seg003:958A0 jb word_FD10.4, loc_8958BE ; S_fgrhs cruise sw jump to loc if relative bit is set
seg003:958A4 movb rl4, nmot ; move n_mot engine speed into r14
seg003:958A8 cmpb rl4, #3Eh ; '>' ; compare r14/nmot with #3Eh
seg003:958AC jmpr cc_ULE, loc_8958BE ; jump to loc if contents of r14 is less than or equal to whatever #3Eh is
seg003:958AE exts #38h, #1 ; '8'
seg003:958B2 movb rl4, wped ; move wped into r14
seg003:958B6 cmpb rl4, #0 ; compare contents of r14 (wped) with 0
seg003:958B8 jmpr cc_NZ, loc_8958BE ; If not zero, jump to location
seg003:958BA mov r4, #0E67h ; move value into r4 to later force lamfaw_w
seg003:958BE
seg003:958BE loc_8958BE: ; CODE XREF: sub_89589C+4j
seg003:958BE ; sub_89589C+10j ...
seg003:958BE extp #0E1h, #1 ; 'ß'
seg003:958C2 mov lamfaw_w, r4 ; move contents of r4 (previously loaded with value to force into lamfaw_w) ito lamfaw_w
seg003:958C6 rets
seg003:958C6 ; End of function sub_89589C
|
|
|
|
|
Logged
|
|
|
|
totti
Full Member
Karma: +15/-29
Offline
Posts: 227
|
|
« Reply #7 on: November 23, 2021, 04:49:46 AM »
|
|
|
Hi,
movb byte_380ADA is for switch off fuel cut. 380ADA is nwe [Wiedereinsetzdrehzahl]. Fill with ff is set the fuel supply resumption engine speed to unrealistically high.
For the lamfaw and zwout you can modify you xdf file and with tunerpro you can adjust these values with the right conversation formula. The code always uses the raw values not the physical representations.
|
|
|
|
|
Logged
|
|
|
|
fknbrkn
Hero Member
Karma: +185/-21
Offline
Posts: 1432
mk4 1.8T AUM
|
|
« Reply #8 on: November 23, 2021, 12:17:50 PM »
|
|
|
Nvm
|
|
|
|
« Last Edit: November 23, 2021, 12:38:27 PM by fukenbroken »
|
Logged
|
|
|
|
|
