|
nyet
|
 |
« Reply #45 on: March 28, 2011, 11:06:46 AM »
|
|
|
Spen, as usual, you rock.
Thank you.
|
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #46 on: March 28, 2011, 11:09:42 AM »
|
|
|
The other axis which Rick says is garbage, isn't. The data is wide, and I suspect the full xdf has it as bytes.
Spen
Here is what i have for 12b04 040325 YUnits ="U/min" 040362 YLabelType =0x1 040364 YEq =0.250000 * X,TH|0|0|0|0| 040515 YLabelSource =0x1 040700 YAddress =0x12B04 040710 YDataSize =2 040720 YAddrStep =2 040750 YOutputDig =0x4 040150 Flags =0x302 |
|
|
|
|
Logged
|
|
|
|
|
|
|
nyet
|
|
« Reply #48 on: March 28, 2011, 02:39:30 PM »
|
|
|
Change to "Flags = 0x301"  Err, im confused. 0x301 is signed, BIG endian 0x02 is unsigned LITTLE endian... i.e. if length is >1, flags should be 0x302 or 0x303, but never 0x301 what am i missing |
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #49 on: March 28, 2011, 02:47:11 PM »
|
|
|
Here is what I have for flags 0x001 - value signed 0x002 - value le 0x040 - xaxis signed 0x100 - xaxis le 0x080 - yaxis signed 0x200 - yaxis le so 0x302 is value, xaxis and yaxis LE KFMIOP has SizeInBits = 0x10 = 2 bytes XDataSize = 2 YDataSize = 2 Which is right %%TABLE%%
000100 Cat0ID =0x11
040005 Title ="KFMIOP"
040010 Desc ="Optimal engine torque map"
040011 DescSize =0x1A
040330 ZUnits ="%"
040050 SizeInBits =0x10
040100 Address =0x16186
040200 ZEq =0.001526 * X,TH|0|0|0|0|
040305 Cols =0xB
040320 XUnits ="%"
040352 XLabelType =0x1
040354 XEq =0.023438 * X,TH|0|0|0|0|
040505 XLabelSource =0x1
040600 XAddress =0x162E8
040610 XDataSize =2
040620 XAddrStep =2
040650 XOutputDig =0x4
040300 Rows =0x10
040325 YUnits ="U/min"
040362 YLabelType =0x1
040364 YEq =0.250000 * X,TH|0|0|0|0|
040515 YLabelSource =0x1
040700 YAddress =0x12B04
040710 YDataSize =2
040720 YAddrStep =2
040750 YOutputDig =0x4
040150 Flags =0x302
%%END%%
|
|
|
|
« Last Edit: March 28, 2011, 03:00:00 PM by nyet »
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #50 on: March 28, 2011, 03:02:41 PM »
|
|
|
Oh, and my KFZWOP is still using the old rpm axis in my last released map pack...
I have not posted the latest one yet.
|
|
|
|
|
Logged
|
|
|
|
spen
Full Member
Karma: +43/-0
 Offline
Posts: 112
|
|
« Reply #51 on: March 28, 2011, 03:37:42 PM »
|
|
|
my xdf output routine produced:
%%TABLE%%
000002 UniqueID =0x0
000100 Cat0ID =0x8
040005 Title ="Optimal ignition angle (KFZWOP)"
040011 DescSize =0x17
040010 Desc ="Optimal ignition angle"
040100 Address =0x1140e
040150 Flags =0x301
040200 ZEq =0.750000 * X,TH|0|0|0|0|
040230 RangeLow =0.0000
040240 RangeHigh =255.0000
040300 Rows =0x10
040305 Cols =0xb
040320 XUnits ="%"
040325 YUnits ="U/min"
040330 ZUnits ="grad KW"
040350 XLabels =0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
040352 XLabelType =0x1
040354 XEq =0.023438 * X,TH|0|0|0|0|
040360 YLabels =0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
040362 YLabelType =0x1
040364 YEq =0.250000 * X,TH|0|0|0|0|
040505 XLabelSource =0x1
040515 YLabelSource =0x1
040600 XAddress =0x162e8
040620 XAddrStep =2
040650 XOutputDig =0x0
040660 XAxisMin =1000.000000
040670 XAxisMax =1000.000000
040700 YAddress =0x12b04
040720 YAddrStep =2
040750 YOutputDig =0x0
040760 YAxisMin =1000.000000
040770 YAxisMax =1000.000000
%%END%%
Back in a minute..
|
|
|
|
« Last Edit: March 28, 2011, 03:51:17 PM by spen »
|
Logged
|
|
|
|
spen
Full Member
Karma: +43/-0
Offline
Posts: 112
|
|
« Reply #52 on: March 28, 2011, 03:45:56 PM »
|
|
|
mm, on version 4.14 tuner pro using flags = 0x301 or flags = 0x302 made no difference to the presentation.
I'll have to find the code and see if I can work out if I misinterpretted the flag bits, as I'm assuming your flag definitions are correct.
What does make a difference is that we're using different map addresses, which means something is wrong. I'm going to double check the map I've identified as kfzwop.
|
|
|
|
« Last Edit: March 28, 2011, 03:53:32 PM by spen »
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #53 on: March 28, 2011, 03:58:55 PM »
|
|
|
I'm assuming your flag definitions are correct.
Bad idea! Check independently!  What does make a difference is that we're using different map addresses, which means something is wrong. I'm going to double check the map I've identified as kfzwop.
I didn't post my kfzwop because my latest released mappack has the wrong rpm axis (it still uses the 8bit 100c2)... here it is anyway for reference %%TABLE%%
000100 Cat0ID =0x8
040005 Title ="KFZWOP"
040010 Desc ="Optimal ignition angle"
040011 DescSize =0x17
040330 ZUnits ="grad KW"
040100 Address =0x1140E
040200 ZEq =0.750000 * X,TH|0|0|0|0|
040305 Cols =0xB
040320 XUnits ="%"
040352 XLabelType =0x1
040354 XEq =0.023438 * X,TH|0|0|0|0|
040505 XLabelSource =0x1
040600 XAddress =0x162E8
040610 XDataSize =2
040620 XAddrStep =2
040650 XOutputDig =0x4
040300 Rows =0x10
040325 YUnits ="U/min"
040362 YLabelType =0x1
040364 YEq =40.000000 * X,TH|0|0|0|0|
040515 YLabelSource =0x1
040700 YAddress =0x100C2
040710 YDataSize =1
040720 YAddrStep =1
040750 YOutputDig =0x4
040150 Flags =0x100
%%END%%
|
|
|
|
|
Logged
|
|
|
|
spen
Full Member
Karma: +43/-0
Offline
Posts: 112
|
|
« Reply #54 on: March 28, 2011, 04:12:14 PM »
|
|
|
Ahh, that's why the addresses are different!
Sorry didn't see you were giving me KFMIOP.
I think KFMIOP has axes at 0x8100dc and 0x812b04; I think your x axis is out. I don't have time to write more I'm out of battery. I'll do an export of KFMIOP as a XDFobject for the M box when I can.
|
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #55 on: March 28, 2011, 04:19:23 PM »
|
|
|
Spen, thanks!
At some point we need to find a decent way of auditing my entire map pack in one fell swoop :/
And then there is the problem of getting a .kp out of an .xdf, and not the other way around, since i use .kp as canonical ...
|
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #56 on: March 28, 2011, 10:41:26 PM »
|
|
|
Nyet,
rpm axis data for timing map in the last xdf you posted look like garbage?
Its a problem with "significant figures" handling in tunerpro. My maps are marked for 4, which is xxxx.xxxx for rpm, which gets truncated to xx.xxxx since the display is limited. Working on setting the right sigfigs now |
|
|
|
« Last Edit: March 28, 2011, 10:53:53 PM by nyet »
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #57 on: March 28, 2011, 11:06:52 PM »
|
|
|
I found a bug in my map conversion program.
It wasn't handling precision correctly.
|
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #58 on: March 28, 2011, 11:28:02 PM »
|
|
|
|
|
|
|
|
Logged
|
|
|
|
|
