Pages: 1 ... 15 16 [17]
Author Topic: ECUxPlot 0.9r6.1 released - please read the FAQ in this thread!  (Read 110112 times)
Lechuga
Jr. Member
**

Karma: +1/-0
Offline Offline

Posts: 29


« Reply #240 on: February 20, 2020, 02:25:17 PM »

I'll submit a PR this weekend
Logged
Lechuga
Jr. Member
**

Karma: +1/-0
Offline Offline

Posts: 29


« Reply #241 on: February 21, 2020, 08:41:20 AM »

Nyet, attached are my changes. I installed eclipse, cloned the GIT repository, made the changes to the code, but could not compile or test because of other bugs elsewhere in the code. So I am attaching the files I changed and I ask that you add them to the repository. Cheers!
Logged
nyet
Administrator
Hero Member
*****

Karma: +454/-65
Offline Offline

Posts: 10420


WWW
« Reply #242 on: February 21, 2020, 11:14:02 AM »

please open a pr
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
Lechuga
Jr. Member
**

Karma: +1/-0
Offline Offline

Posts: 29


« Reply #243 on: February 23, 2020, 02:05:15 AM »

I got a message that you accepted the PR. How long will it take to get added to the nightly builds? TIA
Logged
nyet
Administrator
Hero Member
*****

Karma: +454/-65
Offline Offline

Posts: 10420


WWW
« Reply #244 on: February 23, 2020, 02:14:12 AM »

I got a message that you accepted the PR. How long will it take to get added to the nightly builds? TIA

I closed the PR because it wasn't actually a useful PR. It was a fucking disaster. You opened a PR to merge an ancient branch (my own) into master.

Not sure what you think you are doing, but you should probably learn a bit more about the github PR workflow.
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
Lechuga
Jr. Member
**

Karma: +1/-0
Offline Offline

Posts: 29


« Reply #245 on: February 24, 2020, 01:36:47 AM »

Quote
I closed the PR because it wasn't actually a useful PR. It was a fucking disaster. You opened a PR to merge an ancient branch (my own) into master.

Not sure what you think you are doing, but you should probably learn a bit more about the github PR workflow.

Woah! That's not very helpful.

I only wanted to contribute. I am not a Java developer; I gave you the code changes and asked you politely to merge it and you requested I opened a PR, which I did following the only steps that github allowed me. My apologies if I am unable to jump backwards through hoops to satisfy your expectations. I will not contribute again.

PD: Mind your language.
Logged
adam-
Hero Member
*****

Karma: +103/-25
Online Online

Posts: 1891


« Reply #246 on: February 24, 2020, 01:51:34 AM »

Woah! That's not very helpful.

I'm with you on that, that reply was quite agressive for no reason.  Man was only trying to help.
Logged
nyet
Administrator
Hero Member
*****

Karma: +454/-65
Offline Offline

Posts: 10420


WWW
« Reply #247 on: February 24, 2020, 09:48:00 AM »

Woah! That's not very helpful.

I only wanted to contribute. I am not a Java developer; I gave you the code changes and asked you politely to merge it and you requested I opened a PR, which I did following the only steps that github allowed me. My apologies if I am unable to jump backwards through hoops to satisfy your expectations. I will not contribute again.

PD: Mind your language.

Sorry.

In any case, that isn't at all how github works. Did you review the PR before hitting submit?
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
Lechuga
Jr. Member
**

Karma: +1/-0
Offline Offline

Posts: 29


« Reply #248 on: February 24, 2020, 01:42:44 PM »

Quote
Sorry.

In any case, that isn't at all how github works. Did you review the PR before hitting submit?

Apologies accepted.

Yes. But it did not give me any other options. It was either PR from 'winols' or nothing. Then it asked me to upload the modified files in zip format (which I did) and assumed it was kosher.
Logged
nyet
Administrator
Hero Member
*****

Karma: +454/-65
Offline Offline

Posts: 10420


WWW
« Reply #249 on: February 24, 2020, 02:35:54 PM »

You may want to review the github PR submission workflow.

In general

1) fork the repo to your own github projects
2) git clone your project to a local checkout dir
3) make a PR branch in the local checkout dir
4) make your changes locally
5) do a 'git diff' to make sure they make sense
6) check your changes into the PR branch
7) push the PR branch to your own githpub fork of the project
Cool open a pull request to pull from your fork to main of the upstream repo

All of the above requires a good working knowledge of both git and github.
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
q_dubz
Full Member
***

Karma: +3/-0
Offline Offline

Posts: 147



« Reply #250 on: February 24, 2020, 10:17:22 PM »

You may want to review the github PR submission workflow.

In general

1) fork the repo to your own github projects
2) git clone your project to a local checkout dir
3) make a PR branch in the local checkout dir
4) make your changes locally
5) do a 'git diff' to make sure they make sense
6) check your changes into the PR branch
7) push the PR branch to your own githpub fork of the project
Cool open a pull request to pull from your fork to main of the upstream repo

All of the above requires a good working knowledge of both git and github.

this is typical of engineers  Tongue way more complicated than it needs to be but they don't care, so long as it meets the function requirement!



Logged
adam-
Hero Member
*****

Karma: +103/-25
Online Online

Posts: 1891


« Reply #251 on: February 25, 2020, 01:21:51 AM »

this is typical of engineers  Tongue way more complicated than it needs to be but they don't care, so long as it meets the function requirement!

Literally this.  I tried to use it ages ago and it was a ball-ache.  No need for so many mouse clicks literally to request to change some code.
Logged
nyet
Administrator
Hero Member
*****

Karma: +454/-65
Offline Offline

Posts: 10420


WWW
« Reply #252 on: February 25, 2020, 09:44:32 AM »

Literally this.  I tried to use it ages ago and it was a ball-ache.  No need for so many mouse clicks literally to request to change some code.

You could also send a diff. Or a patch.

But literally the entire open source universe works this way, I have opened literally dozens of PRs with projects that have 100k+ people working on it.

It isn't hard.
Logged

ME7.1 tuning guide (READ FIRST)
ECUx Plot
ME7Sum checksum checker/corrrector for ME7.x

Please do not ask me for tunes. I'm here to help people make their own.

Do not PM me technical questions! Please, ask all questions on the forums! Doing so will ensure the next person with the same issue gets the opportunity to learn from your experience.
Pages: 1 ... 15 16 [17]
  Print  
 
Jump to:  

Powered by SMF 1.1.21 | SMF © 2015, Simple Machines Page created in 0.023 seconds with 18 queries. (Pretty URLs adds 0.001s, 0q)