|
elRey
|
 |
« Reply #285 on: October 05, 2014, 04:45:20 PM »
|
|
|
higher level. why do u want sbbhk set?
laymans terms plz
|
|
|
|
|
Logged
|
|
|
|
|
phila_dot
|
|
« Reply #286 on: October 05, 2014, 05:29:47 PM »
|
|
|
I think he was having problems setting O2 Sensor readiness.
|
|
|
|
|
Logged
|
|
|
|
|
elRey
|
|
« Reply #287 on: October 05, 2014, 07:52:45 PM »
|
|
|
I thought that might be it. masterj, I believe what you're looking for is SRYLS and reduce it by how many o2 sensors you have deleted/disabled.
|
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #288 on: October 05, 2014, 07:54:39 PM »
|
|
|
I thought that might be it. masterj, I believe what you're looking for is SRYLS and reduce it by how many o2 sensors you have deleted/disabled.
Its this restricted to ME7.5? |
|
|
|
|
Logged
|
|
|
|
|
elRey
|
|
« Reply #289 on: October 05, 2014, 09:38:47 PM »
|
|
|
All my experience is with ME7.5. So, I can't say. Sorry.
|
|
|
|
|
Logged
|
|
|
|
|
phila_dot
|
|
« Reply #290 on: October 06, 2014, 09:33:31 AM »
|
|
|
Readiness is set if the counter (cry*) is greater than the SRY threshold.
The SRY thresholds are evaluated when any of the applicable error flags are set.
The counter is initialized with 0 and incremented only when all of the applicable cycle flags are set and also a condition bit. The condition bit is set at initialization and cleared when the counter is incremented. It is also set when the codeword bits are evaluated.
It is my understanding, that the counter is only incremented once because of the condition bit, so the cry counters will never be greater than 1 and the SRY thresholds are all set to 2.
Setting the SRY thresholds to 0 would force readiness when both the cycle and error flag are set.
Not restricted to ME7.5
|
|
|
|
|
Logged
|
|
|
|
|
elRey
|
|
« Reply #291 on: October 06, 2014, 10:02:45 AM »
|
|
|
Setting the SRY thresholds to 0 would force readiness when both the cycle and error flag are set.
Or just reduce it to 1 to still have front o2 sensors required to set readiness. |
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #292 on: October 06, 2014, 10:08:11 AM »
|
|
|
Can I replace all of the S4wiki section that deals with rear O2 removal with the advice to set SRYLS to 0 or 1 (depending on what the person wants, no O2s required, or 2 O2s required)?
|
|
|
|
|
Logged
|
|
|
|
|
phila_dot
|
|
« Reply #293 on: October 06, 2014, 10:08:27 AM »
|
|
|
Or just reduce it to 1 to still have front o2 sensors required to set readiness.
Can you explain the logic? Not doubting you, just trying to figure out what I missed. The counter and threshold doesn't really make functional sense from what I see, but I didn't see anything that supports your logic. |
|
|
|
|
Logged
|
|
|
|
|
phila_dot
|
|
« Reply #294 on: October 06, 2014, 10:10:03 AM »
|
|
|
Can I replace all of the S4wiki section that deals with rear O2 removal with the advice to set SRYLS to 0 or 1 (depending on what the person wants, no O2s required, or 2 O2s required)?
If the codeout is done properly, then the threshold doesn't need to be touched. I would recommend a proper codeout to ensure no unwanted influences. |
|
|
|
|
Logged
|
|
|
|
|
nyet
|
|
« Reply #295 on: October 06, 2014, 10:11:18 AM »
|
|
|
He's saying that two properly working O2 sensors (but no rear O2s) should result in the counter ending up as 2, so SRYLS=1 should be sufficient to allow readiness to be set.
I assume, anyway.
|
|
|
|
|
Logged
|
|
|
|
|
phila_dot
|
|
« Reply #296 on: October 06, 2014, 10:13:31 AM »
|
|
|
He's saying that two properly working O2 sensors (but no rear O2s) should result in the counter ending up as 2, so SRYLS=1 should be sufficient to allow readiness to be set.
I assume, anyway.
I mean per the code because I didn't see any evaluation seperating sensors or anything allowing it to increment based on codewords or anything other than right after reset and possibly one other time. |
|
|
|
« Last Edit: October 06, 2014, 10:16:31 AM by phila_dot »
|
Logged
|
|
|
|
|
masterj
|
|
« Reply #297 on: October 06, 2014, 11:41:41 AM »
|
|
|
I think it is important to set z_lsv, because most of the precat o2 checks are done in a z_lsv & !e_lsv manner
|
|
|
|
|
Logged
|
|
|
|
|
elRey
|
|
« Reply #298 on: October 06, 2014, 11:56:19 AM »
|
|
|
It was a while ago I did this. I could be recalling wrong. I'll look over the code again.
What I do remember is that on the 1.8T with only 2 sensors (1 pre / 1 post), only reducing SRYLS by one allowed readiness bit b_lsrdy to be set even though rear O2 was correctly coded out. (ESKONF, CWKONLS, CDKAT, and CDs related to rear o2)
I believe when I saw "cryls + 1" I assumed it was incrementing on rising edge.
|
|
|
|
|
Logged
|
|
|
|
|
elRey
|
|
« Reply #299 on: October 06, 2014, 12:27:28 PM »
|
|
|
Ah, so what I propose does get z_lsv set then. It seems to bypass it. Bummer.
Then why not change your jmpr cc_NZ to jmpr cc_UC where it checks for b_sbbhk in DLSU. Should be a one byte change. Or change it to check #1 instead if b_sbbhk.
Also, masterj - how did you name each bit in IDA?
|
|
|
|
« Last Edit: October 06, 2014, 12:37:42 PM by elRey »
|
Logged
|
|
|
|
|
