Pages: 1 ... 7 8 [9] 10 11 ... 13
Author Topic: Hitting max ps_w/rl_w and fueling  (Read 151356 times)
britishturbo
Sr. Member
****

Karma: +14/-1
Offline Offline

Posts: 306


« Reply #120 on: November 27, 2012, 05:18:03 AM »

No, for a 4 bar MAP you only need to change DSLGRAD and DSLOFS.
Read this thread through before asking questions or people will soon get pretty grumpy at you.

Now I see it. Thanks. That's pretty simple then really.
Logged
prj
Hero Member
*****

Karma: +1072/-485
Offline Offline

Posts: 6041


« Reply #121 on: November 27, 2012, 05:23:08 AM »

Now I see it. Thanks. That's pretty simple then really.

Yes, it is... the entire initial idea and now the implementation is made with the fact in mind that you can use any MAP sensor up to 5 bar, and only change two values.
All the rescaling only has to be done once...
Logged

PM's will not be answered, so don't even try.
Log your car properly - WinOLS database - Tools/patches
britishturbo
Sr. Member
****

Karma: +14/-1
Offline Offline

Posts: 306


« Reply #122 on: November 27, 2012, 05:57:07 AM »

Yes, it is... the entire initial idea and now the implementation is made with the fact in mind that you can use any MAP sensor up to 5 bar, and only change two values.
All the rescaling only has to be done once...

Good stuff indeed.
Reminds me of the days when I was helping dev 3 bar support in the Megasquirt... glory days :-)
Logged
phila_dot
Hero Member
*****

Karma: +173/-11
Offline Offline

Posts: 1709


« Reply #123 on: November 27, 2012, 06:39:03 AM »

Yes, I figured. I feel we are pretty close to the goal now, then we need to wrap it up and figure out a smart way to hack the ASM for the 1013 divisions(if there is a way besides to disassemble each and every file?).

Then I guess it is wiki time, but I dont feel like it is a good idea to prepare files with this hack and upload for everyone to use, at least not at this point. It would be very good if at least one or two more persons trace the diagrams and implement the hack themselfs, there is likely stuff I have overlooked that someone more experienced may pick up.

When I get to the bottom with the cold start issue I will update my map list.

It shouldn't be too difficult for people to find the constants in hex given a file or two with the locations already identified.

I plan to go through the disassembly and do an M box file when I get some time. I just have to wrap up a couple of thing first. I won't be able to do any testing though, my baby turbos aren't up to it.
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #124 on: November 27, 2012, 08:59:38 PM »

The bottom one doesn't exist for reasons that you should be able to tell by looking at the pic you posted.

The top one can be halved by changing the following bytes:

0x6A3F2 - Change from 0x87 to 0x0E
0x6A3F3 - Change from 0x02 to 0x05

0x6A22E - Change from 0x87 to 0x0E
0x6A22F - Change from 0x02 to 0x05

I think there a few other places you need to do this too.

And we have cold start idle back!

I changed all four of those values, returned KFWDKPP axis to stock and the 0x5F017 bit you gave me back to stock.

Ill do some more logging today after work.
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #125 on: November 27, 2012, 09:03:43 PM »

It shouldn't be too difficult for people to find the constants in hex given a file or two with the locations already identified.

I plan to go through the disassembly and do an M box file when I get some time. I just have to wrap up a couple of thing first. I won't be able to do any testing though, my baby turbos aren't up to it.

Sounds good.

You dont really have to turn the turbos to 23psi+ to test this out?
Logged
matchew
Hero Member
*****

Karma: +47/-22
Offline Offline

Posts: 503


« Reply #126 on: November 27, 2012, 09:27:28 PM »

And we have cold start idle back!

Your welcome!!!
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #127 on: November 27, 2012, 11:36:43 PM »

Your welcome!!!

Thanks for all your help, this would not be possible without your help!

You are a hero Smiley
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #128 on: November 29, 2012, 11:08:19 PM »

After a few starts the cold start idle is not there anymore, drops right to 900rpm again. I find that very strange.. And I dont have the varibles to log this and reverse back to the culprit, ie. Do this the proper way.

I have a few new varibles im going to log after work today, ill get back tonight and share my findings. I do think as matchew says, we need to half more 1013's to get everything in line.

But im going to try get more data first, I dont want to bug you disassemble kings anymore with these ATM divisions, until I have done what I can with what I have.
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #129 on: November 30, 2012, 11:29:40 AM »

So I have found something, pvdk_w is doubled, according to my understanding. I have a few things to try now, need to do some flashing and logging.

Logged
matchew
Hero Member
*****

Karma: +47/-22
Offline Offline

Posts: 503


« Reply #130 on: November 30, 2012, 02:18:27 PM »

Try this, I took literally 30 secs to look at this.

Change 0x69290 from 0x4D to 0x9A
Change 0x69291 from 0x65 to 0xCA

Change 0x694EE from 0x4D to 0x9A
Change 0x694EF from 0x65 to 0xCA
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #131 on: November 30, 2012, 03:26:32 PM »

Try this, I took literally 30 secs to look at this.

Change 0x69290 from 0x4D to 0x9A
Change 0x69291 from 0x65 to 0xCA

Change 0x694EE from 0x4D to 0x9A
Change 0x694EF from 0x65 to 0xCA

matchew, you are a ROCKSTAR!

I defined the last ASM division(-> fpvdkds_w) you gave me as 16bit LoHi, as per my my own assumption, and did the changes per your intructions(I did the changes and afterwards realised it was a word). Could you please give me/us what exactly this change in code does?

And to this new code change you gave me now, what am I altering? I am assuming this change should be done in addition to the last ATM change I did(-> fpvdkds_w)? I am trying to get a better picture of what I am actually doing here with the invalueable help you are providing us.

I hope everyone that is learning something from this thread is giving matchew +rep, he is the one freely sharing the work/information to get this project up and working.

Logged
matchew
Hero Member
*****

Karma: +47/-22
Offline Offline

Posts: 503


« Reply #132 on: November 30, 2012, 05:08:24 PM »

So does this latest update work?

It is to be done in addition to everything else that I have listed that works.
« Last Edit: November 30, 2012, 05:13:18 PM by matchew » Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #133 on: December 03, 2012, 11:37:06 AM »

The bottom one doesn't exist for reasons that you should be able to tell by looking at the pic you posted.

The top one can be halved by changing the following bytes:

0x6A3F2 - Change from 0x87 to 0x0E
0x6A3F3 - Change from 0x02 to 0x05

0x6A22E - Change from 0x87 to 0x0E
0x6A22F - Change from 0x02 to 0x05

I think there a few other places you need to do this too.



Alright, I have been taken some logs and I can confirm this change halfed the top 1013 and get fpvdkds_w sane. I can also mention that my pvdk_w was NOT doubled, I made a mistake when I scaled up my logger definition and scaled up pvdk_w when I was not supposed to.

Ok, with fpvdkds_w confirmed we end up having more trouble here:


(fpvdkds_w * fkmsdk_w) * 1013 = pvdk_w

pvdk_w is then divided at a couple of places with other already scaled pressure variables, one of them ends up screwing up the input to KFWDKMSN. That is what I think is causing my less than optimal cold start.

I have made the last change matchew gave us(which I believe will half the ATM constant that calculates pvdk_w, mentioned above), I will log it tomorrow on my way to work and report my findings.
Logged
Bische
Sr. Member
****

Karma: +25/-4
Offline Offline

Posts: 397



WWW
« Reply #134 on: December 04, 2012, 09:03:20 PM »

Pvdk_w confirmed scaled down now, had to modify matchews last ASM change to get it to work. I will post what I did and the log when I get home.

had a VERY interesting drive to work, car drives like complete HORSESHIT lol. Its either no throttle or full throttle..
Logged
Pages: 1 ... 7 8 [9] 10 11 ... 13
  Print  
 
Jump to:  

Powered by SMF 1.1.21 | SMF © 2015, Simple Machines Page created in 0.024 seconds with 17 queries. (Pretty URLs adds 0.001s, 0q)