Pages: 1 2 [3] 4 5 ... 22
Author Topic: Actual pre-control in LDRPID  (Read 252432 times)
SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #30 on: July 17, 2017, 08:39:08 PM »

Magic is not yet made, but here's a start.  I added the LDRPID Tool to the VisualME7Logger git.

https://github.com/sbloom82/VisualME7Logger

It currently reads a directory of logs, filters the data by accel position, and parses the data into a somewhat usable format.  I've also included my fixed wgdc logs in the resources folder for something to work off of.
Logged
SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #31 on: July 19, 2017, 07:46:35 AM »

committed a few changes.  I've got it now so that the logs are populating absolute pressure values into a grid of DC/RPM.   I need to do something to detect spool up in the data points so it doesn't incorrectly average values of full boost and spool up boost for a given rpm/dc.
That's my progress so far, feel free to download the source and have at'er.
Logged
TijnCU
Hero Member
*****

Karma: +60/-4
Offline Offline

Posts: 690


flying brick


« Reply #32 on: July 19, 2017, 08:23:56 AM »

I have looked at it yesterday, will try to contribute. Good work so far, a solution for spool-up might be to check for a percentage of increase threshold? Once it settles there should not be much increase. Another option is mbar increase per 100rpm or something, maybe keep it a variable to suit different turbo setups.
Logged

SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #33 on: July 23, 2017, 08:29:36 PM »

Here's a first version of the tool.  I just took my first test run with the maps generated from the program and it seems to work pretty well.  I currently have a ton of overshoot in spots, but a little work on q2 should do the trick.   

To tired to explain how it works other than you load in a directory of log files, edit the axis and data that is loaded in, and generate a KFLDRL based on all that.

My log files that I used on the github if you want to mess around.  Otherwise, if anyone has other sets of log files to test with, please share!

edit, latest version of the tool is on the next page.
« Last Edit: July 27, 2017, 11:17:16 AM by SB_GLI » Logged
SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #34 on: July 23, 2017, 08:36:01 PM »

After a tiny bit of massaging, this is what KFLDRL looks like for me.
Logged
contrast
Full Member
***

Karma: +20/-3
Offline Offline

Posts: 215


« Reply #35 on: July 24, 2017, 02:47:27 AM »

Did you set KFLDIMX perfectly linear too?
Logged
TijnCU
Hero Member
*****

Karma: +60/-4
Offline Offline

Posts: 690


flying brick


« Reply #36 on: July 24, 2017, 04:27:25 AM »

Here's a first version of the tool.  
Awesome, I will test this tonight! I dont have a complete set of logs yet but I can verify against my manual work!
I really appreciate your effort in making this a GUI! Hope that there are other C# writers that can contribute in the finetuning of the program!
« Last Edit: July 24, 2017, 04:32:41 AM by TijnCU » Logged

SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #37 on: July 24, 2017, 08:05:01 PM »

Using this method, I can't seem to get this lump of dc out after spool up.  It happens in every gear at every rpm range.  Once it falls back to steady boost is on the money every where, but that damn bump.
Logged
userpike
Hero Member
*****

Karma: +22/-1
Offline Offline

Posts: 763


« Reply #38 on: July 24, 2017, 10:50:05 PM »

Why don't you take some wgdc out where it's 95%?


Maybe the turbo is spooling up so fast that the amount of dc less than 95% on the above plot before the overshoot, isn't enough to allow the turbo to slow down. So 95% wgdc till like 3400 or 3600rpm then drop it.

Or take that hump out of wgdc @ 3900ish?
« Last Edit: July 24, 2017, 11:10:27 PM by userpike » Logged
STEVEPHILP
Full Member
***

Karma: +2/-0
Offline Offline

Posts: 70


« Reply #39 on: July 25, 2017, 01:08:22 AM »

Hi,

This is epic.

Just to clarify:

The line under KFLDIMX is where the values for the relevant IDE column are listed? Do you only need to write one line then?

So for example:

All values in DIMX under 1800mbar are 81%? in the tool?

I only ask becasue you can add more lines to the little DIMX table

Logged

STEVEPHILP
Full Member
***

Karma: +2/-0
Offline Offline

Posts: 70


« Reply #40 on: July 25, 2017, 01:59:54 AM »

In addition, is there a way of getting this tool to work with the following volvo log file format?

I've noticed that it wont parse file if they've been saved as .csv from excel too. (i.e, opened for viewing and saved)

It won't parse them... Will offer a $ contribution if you can...
« Last Edit: July 25, 2017, 03:50:55 AM by STEVEPHILP » Logged

SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #41 on: July 25, 2017, 04:59:44 AM »

Why don't you take some wgdc out where it's 95%?

Or take that hump out of wgdc @ 3900ish?

This happens at all rpms, not just at 3,x00.  I really just need to log all the pid variables to see what part is causing that hump.  I don't think it's influenced by KFLDRL.
Logged
SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #42 on: July 25, 2017, 05:01:47 AM »

All values in DIMX under 1800mbar are 81%? in the tool?

Yes, it only looks at the axis row and the first data row.  If you add more rows, it's not going to do anything with them.
Logged
SB_GLI
Hero Member
*****

Karma: +116/-10
Offline Offline

Posts: 1022


« Reply #43 on: July 25, 2017, 05:21:20 AM »

In addition, is there a way of getting this tool to work with the following volvo log file format?

I've noticed that it wont parse file if they've been saved as .csv from excel too. (i.e, opened for viewing and saved)

It won't parse them... Will offer a $ contribution if you can...

It looks like it parses the log file just fine.. but isn't auto-detecting the variable based on the way the program expects them to be named.   Probably just need to add settings tell the program the variables to use.   For the time being, you can just modify the header row like this:

Time (sec),Pedal Position(%) wped_w,Engine Speed(RPM) nmot_w,

to

Time (sec),wped,nmot_w,

...but I looked at your log, and this is not a fixed DC log.  The program won't work with this.

Here's what it currently expects:
wped,
ldtvm,
nmot or nmot_w,
pvdks_w,
pu or pu_w or defaults to 1000


As for saving the log file to excel format and expecting anything to be able to parse it.... take a long walk off a short cliff.  Wink
Logged
STEVEPHILP
Full Member
***

Karma: +2/-0
Offline Offline

Posts: 70


« Reply #44 on: July 26, 2017, 12:45:01 AM »

Thanks for this. I'll give it a shot.

What I meant was that, if I open one of your own logs in excel and then save it as a CSV (say I change a header value ) then the excel saved CSV won't work. Even if I open a CSV and resave it as a CSV with no changes, it won't parse anymore.

I compared the two rW files, original and excel saved and they look a lot different.

Maybe I'll see if I can find and try a freeware CSV program.

This is still amazing work. Regds
Logged

Pages: 1 2 [3] 4 5 ... 22
  Print  
 
Jump to:  

Powered by SMF 1.1.21 | SMF © 2015, Simple Machines Page created in 0.021 seconds with 17 queries. (Pretty URLs adds 0s, 0q)