Nyet, attached are my changes. I installed eclipse, cloned the GIT repository, made the changes to the code, but could not compile or test because of other bugs elsewhere in the code. So I am attaching the files I changed and I ask that you add them to the repository. Cheers!

I got a message that you accepted the PR. How long will it take to get added to the nightly builds? TIA

Woah! That's not very helpful.

I only wanted to contribute. I am not a Java developer; I gave you the code changes and asked you politely to merge it and you requested I opened a PR, which I did following the only steps that github allowed me. My apologies if I am unable to jump backwards through hoops to satisfy your expectations. I will not contribute again.

PD: Mind your language.

Sorry.

In any case, that isn't at all how github works. Did you review the PR before hitting submit?

You may want to review the github PR submission workflow.

In general

1) fork the repo to your own github projects
2) git clone your project to a local checkout dir
3) make a PR branch in the local checkout dir
4) make your changes locally
5) do a 'git diff' to make sure they make sense
6) check your changes into the PR branch
7) push the PR branch to your own githpub fork of the project
open a pull request to pull from your fork to main of the upstream repo

All of the above requires a good working knowledge of both git and github.

Literally this.  I tried to use it ages ago and it was a ball-ache.  No need for so many mouse clicks literally to request to change some code.

Hi,

i cant figure out why one log is working, the other dont.

regards